Modified Chart Module in order to add dinamically named properties. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e borderWidth and pointRadius
schelling_chart = ChartModule([{"label": "happy", "borderColor": "Black", "borderWidth": "3", "pointRadius": "0"}],
data_collector_name="datacollector")
Fixed variable name.
gotkaren
force-pushed
the
enhanced_chart_module
branch
from
c921048 to
980c8ed
Compare
1 similar comment
|
From a quick glance this looks good, but I guess it breaks the examples!? Can you check and/or update them? |
|
Sure! I'm happy to update them. I'll go back to this pull request after I submit my dissertation (I'm using mesa!). May have more ideas to improve mesa. |
catherinedevlin
pushed a commit
to catherinedevlin/mesa
that referenced
this pull request
Apr 26, 2023
Original work in projectmesa#714
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
|
Superseded by #1685. |
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
pushed a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-Authored-By: Catherine Devlin <devlinch@corning.com>
rht
added a commit
to rht/mesa
that referenced
this pull request
May 9, 2023
Original work: projectmesa#714 and projectmesa#1673. Co-authored-by: Karen Gonzalez <karenyglez.tr@gmail.com> Co-authored-by: rht <rhtbot@protonmail.com>
rht
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e borderWidth and pointRadius
schelling_chart = ChartModule([{"label": "happy",
"borderColor": "Black",
"borderWidth": "3",
"pointRadius": "0"}],
data_collector_name="datacollector")
Before this it was only possible to modifiy label and borderColor for each serie.